Page 1 of 1

Launcher crashing on start

Posted: Fri Jan 05, 2024 9:41 am
by Player Name
Was working fine 15 minutes ago, now suddenly it doesn't start any more. When I run the binary, I see the main screen for about half a second but the news page is blank, and then it crashes.

Code: Select all

Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at Saradomin.Utilities.HtmlRenderer.Visit(HtmlNode htmlNode)
   at Saradomin.Utilities.HtmlRenderer.RenderToContainer()
   at Saradomin.ViewModel.Windows.MainWindowViewModel.MainViewLoaded(MainViewLoadedMessage _)
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at Avalonia.Threading.AvaloniaSynchronizationContext.<>c__DisplayClass5_0.<Post>b__0() in /_/src/Avalonia.Base/Threading/AvaloniaSynchronizationContext.cs:line 33
   at Avalonia.Threading.JobRunner.Job.Avalonia.Threading.JobRunner.IJob.Run() in /_/src/Avalonia.Base/Threading/JobRunner.cs:line 181
   at Avalonia.Threading.JobRunner.RunJobs(Nullable`1 priority) in /_/src/Avalonia.Base/Threading/JobRunner.cs:line 37
   at Avalonia.X11.X11PlatformThreading.CheckSignaled() in /_/src/Avalonia.X11/X11PlatformThreading.cs:line 164
   at Avalonia.X11.X11PlatformThreading.RunLoop(CancellationToken cancellationToken) in /_/src/Avalonia.X11/X11PlatformThreading.cs:line 244
   at Avalonia.Threading.Dispatcher.MainLoop(CancellationToken cancellationToken) in /_/src/Avalonia.Base/Threading/Dispatcher.cs:line 65
   at Avalonia.Controls.ApplicationLifetimes.ClassicDesktopStyleApplicationLifetime.Start(String[] args) in /_/src/Avalonia.Controls/ApplicationLifetimes/ClassicDesktopStyleApplicationLifetime.cs:line 120
   at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime[T](T builder, String[] args, ShutdownMode shutdownMode) in /_/src/Avalonia.Controls/ApplicationLifetimes/ClassicDesktopStyleApplicationLifetime.cs:line 209
   at Saradomin.Program.Main(String[] args)

fish: Job 1, '~/2009scape-launcher-no_rt&' terminated by signal SIGABRT (Abort)
I don't know the framework very well, but guessing from the stack trace it looks like it's having trouble fetching the news page and is getting a null instead? I'm on a flaky wifi connection so it may well be a transient issue on my end (although: other internet things work fine, such as making this post). So: is this happening to other people too? Also, should I file a bug report? I'm inclined to, since crashing is always a bug IMO even if the user is at fault (I would argue that the exception needs to be caught and handled if possible, and if not the user should receive a clean message explaining what's wrong), but staff might have a different opinion so I thought I'd ask first.

Re: Launcher crashing on start

Posted: Fri Jan 05, 2024 9:53 am
by Red Bracket
Uh oh.

Re: Launcher crashing on start

Posted: Fri Jan 05, 2024 9:56 am
by Red Bracket
Fixed. Thanks for reporting :lol:

Re: Launcher crashing on start

Posted: Fri Jan 05, 2024 10:24 am
by Player Name
Yeah, indeed fixed - had I just caught you working on something? :mrgreen: